test: retry fqdn requests, increase curl timeout#11775
Merged
Conversation
|
Please set the appropriate release note label. |
Member
Author
|
test-focus K8sFQDNTest |
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
5d4b069 to
3d4bb6f
Compare
Member
Author
|
test-focus K8sFQDNTest |
qmonnet
reviewed
May 29, 2020
| // seconds longer than CurlConnectTimeout to provide some time to | ||
| // actually transfer data. | ||
| CurlMaxTimeout = 8 | ||
| CurlMaxTimeout = 20 |
Member
There was a problem hiding this comment.
The timeout is used by CurlFail(), which is sometimes supposed to fail. Won't that increase the waiting time for the tests when we expect the connexion to fail?
Member
Author
There was a problem hiding this comment.
@qmonnet this should be handled by CurlConnectTimeout, which is set to 5 (it maps to --connect-timeout flag), so this change shouldn't affect failing connection.
qmonnet
approved these changes
May 29, 2020
tklauser
reviewed
May 29, 2020
Member
Author
|
@tklauser these are supposed to fail, so it didn't flake on us (either there was a connectivity issue or Cilium worked as expected and blocked the request). I don't think there's need to add retries there. |
Member
|
@nebril thanks for the explanation, makes sense. |
tklauser
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.