Conversation
42cb6af to
45b8e9d
Compare
|
Coverage increased (+0.01%) to 36.841% when pulling ed573255411004776e371a3452b115c71f7ee1c1 on pr/add-scalability-guide into 3dc573e on master. |
Contributor
michi-covalent
left a comment
There was a problem hiding this comment.
thanks @aanm a fascinating read. all of my comments are minor nits.
qmonnet
reviewed
May 29, 2020
aanm
commented
May 29, 2020
Member
Author
aanm
left a comment
There was a problem hiding this comment.
Thank you for the reviews @qmonnet and @michi-covalent
45b8e9d to
ed57325
Compare
pchaigno
requested changes
May 29, 2020
Member
pchaigno
left a comment
There was a problem hiding this comment.
Nits on English.
I love the graphical explanations of resource usage behaviors in the step-by-step deployment 😍
michi-covalent
approved these changes
May 29, 2020
joestringer
reviewed
May 30, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Couple of minor nits; I didn't review in more depth since it seems like @pchaigno has that covered :-)
Signed-off-by: André Martins <andre@cilium.io>
ed57325 to
ee9d212
Compare
pchaigno
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Martins andre@cilium.io