connectivity-check: Do not perform hostport in standard check#11715
Merged
connectivity-check: Do not perform hostport in standard check#11715
Conversation
Due to HostPort not being enabled by default, do not perform the check by default. Require the "connectivity-check-hostport.yaml" to be deployed. Fixes: #11563 Signed-off-by: Thomas Graf <thomas@cilium.io>
Contributor
Author
|
test-focus K8sConformance* |
michi-covalent
approved these changes
May 28, 2020
Contributor
michi-covalent
left a comment
There was a problem hiding this comment.
lgtm, maybe keep the note with a slight modification.
|
|
||
| .. note:: | ||
|
|
||
| Depending on the kernel version you are running on, the HostPort feature may |
Contributor
There was a problem hiding this comment.
seems like this note can still be useful with a slight modification so that people know there is a separate yaml file they can deploy to test this feature if it's enabled:
kubectl apply -f \ |SCM_WEB|\/examples/kubernetes/connectivity-check/connectivity-check-hostport.yaml
aanm
approved these changes
May 29, 2020
joestringer
approved these changes
May 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to HostPort not being enabled by default, do not perform the check
by default. Require the "connectivity-check-hostport.yaml" to be
deployed.
Fixes: #11563