test: Add externalIPs tests to K8sServicesTest and disable K8sKubeProxyFreeMatrix#11696
test: Add externalIPs tests to K8sServicesTest and disable K8sKubeProxyFreeMatrix#11696
Conversation
f247f50 to
2659f43
Compare
|
test-me-please |
It covers both - bpf_host and bpf_sock. Signed-off-by: Martynas Pumputis <m@lambda.lt>
The new name describes better what the function supposed to test. Signed-off-by: Martynas Pumputis <m@lambda.lt>
The suite does not provide much value because of the following reasons: - It does not test the kube-proxy replacement from outside, so only bpf_sock is tested. - K8sServicesTest should provide the same coverage. - It takes 20min to run the suite. Signed-off-by: Martynas Pumputis <m@lambda.lt>
| func skipSuite(name string, t func()) bool { | ||
| return false | ||
| } | ||
|
|
||
| // Replace "skipSuite" with "Describe" to enable the suite. | ||
| var _ = skipSuite("K8sKubeProxyFreeMatrix tests", func() { |
There was a problem hiding this comment.
What are we gaining by disabling this entire suite? This is testing 396 different test cases in 15 minutes which is roughly 2.7 seconds per test case.
There was a problem hiding this comment.
20min for each test-net-next run to test just bpf_sock implementation is imho too much, considering that K8sServicesTest already does it.
If we want to test with all possible permutations, we can run the K8sKubeProxyFreeMatrix suite manually, same as we do e.g. with -race.
There was a problem hiding this comment.
But the K8sServicesTest is only a subset of all tests written in K8sKubeProxyFreeMatrix
There was a problem hiding this comment.
Yeah, but K8sServicesTest should have the full coverage of bpf_sock.
|
retest-4.19 |
|
4.19 failed due to L7+NodePort flake. |
|
Marking for backports mostly to disable the |
See commit msgs.
test-net-nextshould run ~20min faster.Fix #11442.