Skip to content

vbox: update net-next box and runtime/builder images#11649

Merged
borkmann merged 2 commits intomasterfrom
pr/update-packer-ci-build
May 22, 2020
Merged

vbox: update net-next box and runtime/builder images#11649
borkmann merged 2 commits intomasterfrom
pr/update-packer-ci-build

Conversation

@borkmann
Copy link
Copy Markdown
Member

@borkmann borkmann commented May 22, 2020

borkmann added 2 commits May 22, 2020 09:47
@borkmann
vagrant: bump net-next vagrant box version
74ed970 
Pull in bpf-next kernel changes for getpeername cgroup hook [0].

  [0] https://lore.kernel.org/bpf/cover.1589841594.git.daniel@iogearbox.net/

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
docker: update cilium-{runtime,builder} images
b42d414 
Pull in bpf-next bpftool changes for CONFIG_HZ and getpeername cgroup
hook [0,1].

  [0] https://lore.kernel.org/bpf/20200513075849.20868-1-daniel@iogearbox.net/
  [1] https://lore.kernel.org/bpf/cover.1589841594.git.daniel@iogearbox.net/

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann requested a review from pchaigno May 22, 2020 07:49
@borkmann borkmann requested review from a team as code owners May 22, 2020 07:49
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented May 22, 2020

Please set the appropriate release note label.

@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label May 22, 2020
@borkmann borkmann added pending-review area/docker Impacts the integration with Docker. labels May 22, 2020
@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

test-me-please

@borkmann borkmann mentioned this pull request May 22, 2020
Merged
@coveralls
Copy link
Copy Markdown

coveralls commented May 22, 2020

Coverage Status

Coverage decreased (-0.007%) to 36.865% when pulling b42d414 on pr/update-packer-ci-build into 054dd16 on master.

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

retest-runtime

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

retest-4.19

1 similar comment
@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

retest-4.19

nebril
nebril approved these changes May 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit privileged tests on runtime, I think it's good to merge as soon as 4.19 build passes

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020 •
edited
Loading

retest-4.19 (https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/1659/), Hit: #11313

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

retest-4.19

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

4.19: fatal: unable to access 'https://github.com/cilium/cilium/': The requested URL returned error: 500

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

retest-4.19

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

4.19:

20:23:00  VBoxManage: error: Machine '4b77ad3f-b7a0-4088-9235-7aaadc9dbbb2' is not currently running
20:23:00  0%...10%...20%...30%...40%...
20:23:00  Progress state: VBOX_E_INVALID_OBJECT_STATE
20:23:00  VBoxManage: error: Machine delete failed
20:23:00  VBoxManage: error: Medium '/root/VirtualBox VMs/ubuntu-18.04.4-amd64-13_1590178439986_35406/ubuntu-18.04.4-amd64-13-disk001.vmdk' is locked for reading by another task
20:23:00  VBoxManage: error: Details: code VBOX_E_INVALID_OBJECT_STATE (0x80bb0007), component MediumWrap, interface IMedium
20:23:00  VBoxManage: error: Context: "RTEXITCODE handleUnregisterVM(HandlerArg*)" at line 162 of file VBoxManageMisc.cpp
20:23:00  0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
20:23:02  0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%

@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented May 22, 2020

The only change that is related to 4.19 is the bpftool / iproute2 update in the runtime. 4.19 is flaky in CI and hitting issues in unrelated places to this change, e.g. in one run all tests pass except a known L7 flake. Given the very same bpftool / iproute2 binary runs through on net-next and 4.9, lets proceed.

@borkmann borkmann merged commit a9af784 into master May 22, 2020
@borkmann borkmann deleted the pr/update-packer-ci-build branch May 22, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser approved these changes

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees

No one assigned

Labels

area/docker Impacts the integration with Docker. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@borkmann @coveralls @tklauser @nebril @pchaigno