Vagrantfile, tests: change VM naming scheme#1162
Merged
Conversation
Member
Author
|
Before, to name the VMs we were using the Jenkins-provided JOB_NAME variable, which is set was follows for a PR: There is another environment variable provided by Jenkins, JOB_BASE_NAME, which is set as follows for a PR: For master, JOB_NAME is set as follows: And JOB_BASE_NAME is set as follows: Before we were trying to extract the string "PR" from the JOB_NAME, but there is no such string in master builds. This will fix that issue. |
Use JOB_BASE_NAME variable instead of JOB_NAME for VM names Signed-off by: Ian Vernon <ian@covalent.io>
df7d38f to
da78750
Compare
tgraf
approved these changes
Jul 21, 2017
Contributor
|
Awesome work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use JOB_BASE_NAME variable instead of JOB_NAME for VM names
Signed-off by: Ian Vernon ian@covalent.io