Shorten dummy device name in linuxrouting tests#11555
Merged
joestringer merged 1 commit intomasterfrom May 15, 2020
Merged
Conversation
|
Please set the appropriate release note label. |
Member
Author
|
test-me-please |
aanm
approved these changes
May 15, 2020
Due to the refactor from #11452, the device name was renamed from "enirouting-test" to "linuxrouting-test" which is 17 characters long, exceeding the max device name size (`IFNAMSIZ`) of 16. [1] This commit renames the device name to be under 16 characters. Fixes #11547 Fixes #11452 [1]: https://elixir.bootlin.com/linux/v5.6/source/include/uapi/linux/if.h#L33 Signed-off-by: Chris Tarazi <chris@isovalent.com>
efc8905 to
522db25
Compare
Member
Author
|
test-me-please Edit: runtime tests failed on cleaning up KVStore, seems like a flake: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/187/ |
joestringer
approved these changes
May 15, 2020
pchaigno
approved these changes
May 15, 2020
Member
Author
|
retest-runtime |
tgraf
approved these changes
May 15, 2020
Member
|
This only affects the runtime CI test, happy to merge with a pass on that CI check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the refactor from #11452, the device name was renamed from
"enirouting-test" to "linuxrouting-test" which is 17 characters long,
exceeding the max device name size (
IFNAMSIZ) of 16. 1This commit renames the device name to be under 16 characters.
Fixes #11547
Fixes #11452
Note to backporters: this PR depends on #11452 being backported