Skip to content

eni/routing: disable non-working unit tests#11546

Closed
aanm wants to merge 1 commit intomasterfrom
pr/fix-runtime-tests
Closed

eni/routing: disable non-working unit tests#11546
aanm wants to merge 1 commit intomasterfrom
pr/fix-runtime-tests

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented May 15, 2020 •
edited
Loading

Fixes: a83d538 ("Add unit-tests for enirouting package")
Signed-off-by: André Martins andre@cilium.io

These tests are currently failing:

START: routing_test.go:71: LinuxRoutingSuite.TestDelete
valid IP addr matching rules
Inside new network ns NS(3:4026532400)
routing_test.go:130:
    runFuncInNetNS(c, func() {
        ip := tt.preRun()
        err := Delete(ip)
        c.Assert((err != nil), Equals, tt.wantErr)
    }, masterMAC)
routing_test.go:219:
    c.Assert(err, IsNil)
... value syscall.Errno = 0x22 ("numerical result out of range")

Closed new network ns NS(3:4026532400)
FAIL: routing_test.go:71: LinuxRoutingSuite.TestDelete

START: routing_test.go:63: LinuxRoutingSuite.TestDeleteRoutewithIncompatibleIP
level=warning msg="Unable to delete rules because IP is not an IPv4 address" endpointIP="fd00::2" subsys=linux-routing
PASS: routing_test.go:63: LinuxRoutingSuite.TestDeleteRoutewithIncompatibleIP   0.000s

OOPS: 2 passed, 2 FAILED
--- FAIL: Test (0.01s)
FAIL
coverage: 2.5% of statements in ./...
FAIL    github.com/cilium/cilium/pkg/datapath/linux/routing     0.052s
FAIL
Makefile:142: recipe for target 'tests-privileged' failed

Fixes #11512

@aanm
eni/routing: disable non-working unit tests
2bae188 
Fixes: a83d538 ("Add unit-tests for enirouting package")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested a review from a team May 15, 2020 11:57
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented May 15, 2020

Please set the appropriate release note label.

@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 15, 2020

test-me-please

@aanm aanm added kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI. labels May 15, 2020
@aanm aanm mentioned this pull request May 15, 2020
Closed
tklauser
tklauser requested changes May 15, 2020
View reviewed changes
Comment thread pkg/datapath/linux/routing/routing_test.go
var _ = Suite(&LinuxRoutingSuite{})

func (e *LinuxRoutingSuite) TestConfigure(c *C) {
c.Skip("Not working")
Copy link
Copy Markdown
Member

@tklauser tklauser May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reference issue #11547 in the skip message, so we know why they're not working and sure to remove the skip once the issue is solved.

@coveralls
Copy link
Copy Markdown

coveralls commented May 15, 2020

Coverage Status

Coverage increased (+0.002%) to 37.001% when pulling 2bae188 on pr/fix-runtime-tests into fac1802 on master.

@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 15, 2020

The tests still failed. Closing.

@aanm aanm closed this May 15, 2020
@aanm aanm deleted the pr/fix-runtime-tests branch July 6, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser requested changes

Assignees

No one assigned

Labels

kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: 4.9 Ginkgo-CI-Tests-runtime-Pipeline broken

3 participants

@aanm @coveralls @tklauser