service/test: Fix waiting in testSessionAffinity and regroup affinity match map updates#11519
Merged
service/test: Fix waiting in testSessionAffinity and regroup affinity match map updates#11519
Conversation
|
Please set the appropriate release note label. |
2 similar comments
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
Member
Author
|
test-me-please |
5a5a9ad to
bf44f71
Compare
Member
Author
|
test-me-please |
joestringer
reviewed
May 13, 2020
Member
Author
|
test-focus K8sService* |
bf44f71 to
22a69a5
Compare
Member
Author
|
test-focus .sessionAffinity. |
Member
Author
|
test-focus K8sService* |
22a69a5 to
b0d0838
Compare
Member
Author
|
test-focus K8sService* |
Member
Author
|
test-me-please |
qmonnet
reviewed
May 14, 2020
qmonnet
reviewed
May 14, 2020
Member
qmonnet
left a comment
There was a problem hiding this comment.
Looks good, and nice catch! One question.
b0d0838 to
d5520c2
Compare
Member
Author
|
test-focus K8sService* |
Previously, the waiting for the cilium endpoint was broken in testSessionAffinity helper: jq didn't return error after the endpoint has been removed, which lead to the long duration times. Fixing the jq issue revealed, that it's not enough to wait until the endpoint has disappeared from "cilium endpoints list". Further debugging has shown, that the first request from outside after the pod removal was failing because the IPCache entry was missing for the new pod at the time the request was sent which lead to the packet drop (see the comment in the test helper for more details). Signed-off-by: Martynas Pumputis <m@lambda.lt>
Add matches for new backends after the backends have been inserted into the BPF maps. Otherwise, if an affinity for the svc existed before and its backend ID == the new backend ID, then the new backend will be selected which is missing for a short period of time in the map (until it's inserted). Signed-off-by: Martynas Pumputis <m@lambda.lt>
qmonnet
approved these changes
May 14, 2020
Member
qmonnet
left a comment
There was a problem hiding this comment.
Thanks for the change, looks all good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit msgs.
Fix #11296
Partially_fix #11442