ci/hubble: Fully remove Cilium installation#11141
Merged
Conversation
We are generating the Cilium YAML which contains more pods than just the Cilium DaemonSet (the `hubble-cli` DaemonSet in this case). Therefore, we should also remove everything we generate. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Member
Author
|
test-me-please |
raybejjani
approved these changes
Apr 24, 2020
errordeveloper
approved these changes
Apr 24, 2020
nebril
approved these changes
Apr 24, 2020
Member
nebril
left a comment
There was a problem hiding this comment.
DeleteCiliumDS also waits for all Cilium pods to be terminated, but I think we are good here since next line does just that.
Member
Author
|
test-gke |
1 similar comment
Member
Author
|
test-gke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are generating the Cilium YAML which contains more pods than just the
Cilium DaemonSet (the
hubble-cliDaemonSet in this case). Therefore, weshould also remove everything we generate.