Dockerfiles: Add git log when checking out from git#10819
Conversation
|
test-me-please |
aanm
left a comment
There was a problem hiding this comment.
This requires an update of the runtime and builder image tags in quay.io; update these new tags in this PR; finally run the CI with these new tags.
ecaf271 to
e809d00
Compare
|
Waiting on this build to tag: https://quay.io/repository/cilium/cilium-runtime/build/53f65119-ea0c-4326-b8de-e26117694865 |
e809d00 to
ed560cd
Compare
|
test-me-please |
|
restart-ginkgo |
|
Hit #10882 which seems like a flake, unless the cilium-runtime image here is somehow pulling in something else that was merged but not yet part of the image. Will re-run ginkgo. |
|
restart-ginkgo |
|
restart-ginkgo |
|
Vagrant index problem: |
|
restart-ginkgo |
|
This PR conflicts with open PR #10912 in case one is merged the other needs to be rebased |
|
Hit #10882 on k8s-1.11 / net-next run again. Doesn't seem related to the changes made in this PR, so it seems like master is already broken :( More investigation necessary.... |
|
restart-ginkgo EDIT: Hit #10882 again, seems like it's reliably failing the same way. More likely it's an issue on master that was not yet resolved. |
For all of the commands we run in dockerfiles where we check out code from git, we should run `git log -1` so that in the logs of the docker generation we can tell exactly which commit is checked out and in use for that particular docker image, using only the docker build logs. Signed-off-by: Joe Stringer <joe@cilium.io>
ed560cd to
c623e97
Compare
|
test-me-please |
For all of the commands we run in dockerfiles where we check out code
from git, we should run
git remote -vandgit log -1so that in the logs of the dockergeneration we can tell exactly which commit is checked out, and from where,
for that particular docker image, using only the docker build logs.
Update the cilium-runtime build steps for this.