Makefiles: Disable CGO globally#10724
Merged
aanm merged 1 commit intocilium:masterfrom Apr 2, 2020
Merged
Conversation
Member
Author
|
test-me-please |
Member
Author
|
I guess we use it for proxylib, will need to fix that up.. |
66addcd to
4b03a76
Compare
Member
Author
|
test-me-please Edit: Kafka flakes; fix has been merged: #10721 |
christarazi
approved these changes
Mar 26, 2020
borkmann
approved these changes
Mar 26, 2020
Member
|
test-me-please |
tklauser
approved these changes
Mar 26, 2020
tklauser
reviewed
Mar 26, 2020
Member
tklauser
left a comment
There was a problem hiding this comment.
I think you'll need to drop CGO_ENABLED=0 from the go vet commands for proxylib. See the Travis CI failure.
4b03a76 to
ef582ad
Compare
Member
Author
|
test-me-please |
Member
Author
|
Oh, originally I thought it was go vet but it looks like it's actually the go tests in the proxylib directory. |
ef582ad to
0c7f9df
Compare
Member
Author
|
test-me-please |
Member
Author
|
Plenty of scary-looking failures in CI, will need to investigate further: |
CGo is not necessary for any Cilium binaries, and with the new docs
builder image it's causing build issues like the following:
GEN Documentation/cmdref
Error relocating /src/cilium/cilium: __vfprintf_chk: symbol not found
Error relocating /src/cilium/cilium: __fprintf_chk: symbol not found
Fix this by just disabling it for all targets that use $GO.
Signed-off-by: Joe Stringer <joe@cilium.io>
0c7f9df to
5a264bc
Compare
Member
Author
|
test-me-please EDIT: Only one of the kernel builds failed, due to flake #10821 which looks like infrastructure issue. |
tklauser
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CGo is not necessary for any Cilium binaries (only proxylib), and with
the new docs builder image it's causing build issues like the following
on master for some developers:
Fix this by just disabling it for all targets that use $GO.