hubble-proxy: implement 'serve' command#10653
Merged
Conversation
aanm
reviewed
Mar 20, 2020
92b4004 to
5cb87fb
Compare
gandro
reviewed
Mar 23, 2020
Member
gandro
left a comment
There was a problem hiding this comment.
Looks good! Just some minor nits.
ad2827a to
634f388
Compare
gandro
approved these changes
Mar 23, 2020
michi-covalent
approved these changes
Mar 24, 2020
glibsm
reviewed
Mar 24, 2020
glibsm
requested changes
Mar 24, 2020
glibsm
approved these changes
Mar 24, 2020
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The newly introduced hubble-proxy component needs to connect to a hubble server via a unix domain socket in order to query the API for initial peer discovery. This commit updates cilium-agent such that when hubble is enabled, it automatically listens on a unix domain socket. In order to easily enable or disable the hubble server, a new switch is also added. Note that it using unix domain sockets as listen address is no longer enforced and a warning is emitted instead. In the future, mutual TLS will be implemented to secure connections but for the time being, allowing to listen on a TCP port will allow development of the multi-node feature for Hubble. This commit also updates some logging messages to the error level rather than warning when the hubble component cannot be started. Note that some variables (api => restAPI) had to be renamed to avoid a name conflict when importing the api package but there are no functional changes there. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
This commit adds package pkg/hubbel/proxy with an implementation of hubble's ObserverServer interface. For the time being, the implementation simply connects to the locally running hubble instance via unix domain sockets and forward requests there. In the future, the proxy API will be extended and decoupled from hubble's own API. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The newly introduce 'serve' command runs a hubble-proxy server that, for the time being, forwards requests to the local hubble instance connected to via unix domain socket. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
This commit brings no functional changes. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
634f388 to
100dd63
Compare
Member
Author
|
test-me-please
|
Member
Author
|
test-me-please |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please, look at individual commits for details.
This PR implements a very basic hubble-proxy
servecommand that proxies requests to the local hubble instance connected to via unix domain socket.Ref: https://github.com/cilium/hubble/issues/89