cli: do not output shell completion copyright header on error#10558
Merged
joestringer merged 1 commit intomasterfrom Mar 12, 2020
Merged
cli: do not output shell completion copyright header on error#10558joestringer merged 1 commit intomasterfrom
joestringer merged 1 commit intomasterfrom
Conversation
Before this commit, the copyright header was always displayed when running `cilium completion ...`, even on error such as when an invalid argument is provided. This commit ensures that the copyright header is printed out only when shell completion is actually printed out. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Member
Author
|
test-me-please |
Member
Author
Test flake, let's trigger it again. |
Member
Author
|
test-me-please |
joestringer
approved these changes
Mar 12, 2020
Member
|
I doubt that the CI tests are going to do anything that validates the changes in the command completion here (other than the compile precheck). Changes LGTM, if they break something we can fix it in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the copyright header was always displayed when running
cilium completion ..., even on error such as when an invalid argument is provided.This commit ensures that the copyright header is printed out only when shell completion is actually printed out.
This change is