Fix dead link in 1.4->1.5 upgrade documentation#10416
Merged
joestringer merged 1 commit intocilium:masterfrom Mar 3, 2020
Merged
Fix dead link in 1.4->1.5 upgrade documentation#10416joestringer merged 1 commit intocilium:masterfrom
joestringer merged 1 commit intocilium:masterfrom
Conversation
|
Release note label not set, please set the appropriate release note. |
joestringer
requested changes
Mar 3, 2020
Member
|
btw @Ropes if you use |
The broken link was caused by using the 'latest' URL domain and path as root. \ |SCM_WEB|\/examples/kubernetes/1.10/cilium-pre-flight-with-rm-svc-v2.yaml Therefore the URL picked up the most recent tags, and post 1.5.12 the path `/examples/kubernetes/1.X` were removed, so all newly built URLs were broken. This change makes the URL static to the release path of `1.5.12`. If there are other options to keep the URL tagged within the `1.5.x` minor versions; I'm interested in learning about it, but this is a quick fix. Fixes: cilium#10391 Signed-off-by: Joshua Roppo <joshroppo@gmail.com>
e335672 to
ee5d776
Compare
Contributor
Author
|
URL updated to use the Thanks for the |
joestringer
approved these changes
Mar 3, 2020
Member
|
test-docs-please |
Contributor
Author
|
Oh joy... test build failed for the reason I outlined on the issue. Guess I'll make a PR to shave that yak too. |
Contributor
Author
|
PR up to fix |
aanm
approved these changes
Mar 3, 2020
Contributor
Author
|
test-docs-please |
1 similar comment
Member
|
test-docs-please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broken link was caused by using the 'latest' URL domain and path as
root. \ |SCM_WEB|/examples/kubernetes/1.10/cilium-pre-flight-with-rm-svc-v2.yaml
Therefore the URL picked up the most recent tags, and post 1.5.12 the
path
/examples/kubernetes/1.Xwere removed, so all newly built URLs were broken.eg:
...githubusercontent.com/cilium/cilium/1.7.0/examples/kubernetes/1.10..., all /1.1X/ donot exist in tags newer than 1.5.12.
This change makes the URL static to the release path of
1.5.12. Ifthere are other options to keep the URL tagged within the
1.5.xminorversions; I'm interested in learning about it, but this is a quick fix.
Fixes: #10391
Signed-off-by: Joshua Roppo joshroppo@gmail.com
This change is