test: Avoid using global map for Cilium configuration#10388
Merged
Conversation
The same instance of the configuration map is shared among the tests. So, any modification to the map might unintentionally influence non-related test case. Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
Release note label not set, please set the appropriate release note. |
4 similar comments
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
Member
Author
|
test-me-please |
joestringer
approved these changes
Feb 29, 2020
Member
There was a problem hiding this comment.
Seems not ideal, and safe to merge of course, though I think ginkgo gives us a guarantee that the tests will be run in order so I don't think this makes a practical difference for current tests?
Still it's bad style so good idea to merge. Not sure it makes a difference for backport.
pchaigno
approved these changes
Feb 29, 2020
tgraf
approved these changes
Feb 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same instance of the configuration map is shared among the tests. So, any modification to the map might unintentionally influence a non-related test case.
This change is