Skip to content

bpf: Fix native dev cleanup#10352

Merged
aanm merged 1 commit intomasterfrom
pr/brb/fix-tc-cleanup
Feb 27, 2020
Merged

bpf: Fix native dev cleanup#10352
aanm merged 1 commit intomasterfrom
pr/brb/fix-tc-cleanup

Conversation

@brb
Copy link
Copy Markdown
Member

@brb brb commented Feb 26, 2020 •
edited
Loading

🤦‍♂️ Adding to my TODO to write tests for it (it's already there).

Fixes: 1239278 ("bpf: Remove bpf_netdev.o from previously used devices")

This change is Reviewable

@brb
bpf: Fix native dev cleanup
8050af0 
Fixes: 1239278 ("bpf: Remove bpf_netdev.o from previously used devices")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added kind/bug This is a bug in the Cilium logic. pending-review release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Feb 26, 2020
@brb brb requested a review from a team February 26, 2020 19:57
@brb
Copy link
Copy Markdown
Member Author

brb commented Feb 26, 2020

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 26, 2020

Coverage Status

Coverage decreased (-0.03%) to 45.429% when pulling 8050af0 on pr/brb/fix-tc-cleanup into c9de62b on master.

joestringer
joestringer approved these changes Feb 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@joestringer joestringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there? Then how did it pass CI before?

EDIT: Oh, I guess you mean it's in your TODOs. OK. 👍

@brb
Copy link
Copy Markdown
Member Author

brb commented Feb 27, 2020

Tests failed due CI instability, e.g.:

time="2020-02-26T21:01:12Z" level=error msg="Error executing command 'kubectl -n kube-system logs --timestamps=true -l k8s-app=cilium --since=0.000297063s --previous'" error="signal: killed"
time="2020-02-26T21:01:12Z" level=error msg="Error executing command 'kubectl -n kube-system logs --timestamps=true -l k8s-app=cilium --since=0.000297063s --previous'" error="signal: killed"

Re-running.

@brb
Copy link
Copy Markdown
Member Author

brb commented Feb 27, 2020

test-me-please

@brb
Copy link
Copy Markdown
Member Author

brb commented Feb 27, 2020 

 > git fetch --tags --progress https://github.com/cilium/cilium +refs/pull/*:refs/remotes/origin/pr/* --depth=1 # timeout=20
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from https://github.com/cilium/cilium
	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)

Re-running.

@brb
Copy link
Copy Markdown
Member Author

brb commented Feb 27, 2020

test-me-please

@aanm aanm merged commit 0c67ebf into master Feb 27, 2020
@aanm aanm deleted the pr/brb/fix-tc-cleanup branch February 27, 2020 13:22
@brb brb mentioned this pull request Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser approved these changes

@borkmann borkmann borkmann approved these changes

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

Assignees

No one assigned

Labels

kind/bug This is a bug in the Cilium logic. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brb @coveralls @tklauser @borkmann @joestringer @aanm