-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Helm: operator crashes due to intervalSeconds in Values #44206
Copy link
Copy link
Closed
Labels
kind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/community-reportThis was reported by a user in the Cilium community, eg via Slack.This was reported by a user in the Cilium community, eg via Slack.needs/triageThis issue requires triaging to establish severity and next steps.This issue requires triaging to establish severity and next steps.
Description
Is there an existing issue for this?
- I have searched the existing issues
Version
equal or higher than v1.19.0 and lower than v1.20.0
What happened?
- helm install cilium cilium/cilium --version 1.19.0
- cilium operator crash
How can we reproduce the issue?
$ helm template cilium cilium/cilium --version 1.19.0 --set operator.unmanagedPodWatcher.intervalSeconds=15 | grep unmanaged-pod-watcher-interval
unmanaged-pod-watcher-interval: "15"
This will cause cilium operator crash because "15" is not a valid time.Duration, it should be "15s"
Cilium Version
1.19.0
Kernel Version
6.12
Kubernetes Version
1.35
Regression
No response
Sysdump
No response
Relevant log output
Anything else?
This bug occurs because you're assuming Helm will always parse integers in values.yaml as float64. In reality, they could also be interpreted as int64 or json.Number depending on the context and helm version.
In certain Helm versions, this is even easier to reproduce.
$ helm template cilium cilium/cilium --version 1.19.0 | grep unmanaged-pod-watcher-interval
unmanaged-pod-watcher-interval: "15"
In some other versions, it works as expected.
$ helm template cilium cilium/cilium --version 1.19.0 | grep unmanaged-pod-watcher-interval
unmanaged-pod-watcher-interval: "15s"
Cilium Users Document
- Are you a user of Cilium? Please add yourself to the Users doc
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/community-reportThis was reported by a user in the Cilium community, eg via Slack.This was reported by a user in the Cilium community, eg via Slack.needs/triageThis issue requires triaging to establish severity and next steps.This issue requires triaging to establish severity and next steps.