-
Notifications
You must be signed in to change notification settings - Fork 3.7k
CFP: Include BGP peer capabilities into sysdump #30785
Copy link
Copy link
Labels
area/bgpImpacts the Border Gateway Protocol feature.Impacts the Border Gateway Protocol feature.good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.Good starting point for new developers, which requires minimal understanding of Cilium.help-wantedYou can help! Post a detailed plan on the issue or create a PR to solve this issue.You can help! Post a detailed plan on the issue or create a PR to solve this issue.kind/cfpCilium Feature ProposalCilium Feature Proposalkind/featureThis introduces new functionality.This introduces new functionality.
Metadata
Metadata
Assignees
Labels
area/bgpImpacts the Border Gateway Protocol feature.Impacts the Border Gateway Protocol feature.good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.Good starting point for new developers, which requires minimal understanding of Cilium.help-wantedYou can help! Post a detailed plan on the issue or create a PR to solve this issue.You can help! Post a detailed plan on the issue or create a PR to solve this issue.kind/cfpCilium Feature ProposalCilium Feature Proposalkind/featureThis introduces new functionality.This introduces new functionality.
Type
Projects
Status
Done
Cilium Feature Proposal
Include BGP peer capabilities into sysdump for better supportability
Is your proposed feature related to a problem?
We needed to ask users to provide an output from the peer side like this several times. When the session is established, Cilium (GoBGP) knows the peer's capabilities. In such a case, we don't need to ask for peer's capabilities.
Describe the feature you'd like
(Optional) Describe your proposed solution
We can extend an existing
cilium-dbg bgp peerscommand (which means extend agent API) to include peer capabilities. Cilium CLI can collect the output of thecilium-dbgcommand and show a cluster-wide view. We do a similar thing forcilium routes. As we do for the path attributes in thecilium routescommand, we can encode raw capability binaries into base64 and pretty print it using the GoBGP library on the receiver side. So that we don't need to write String() for every capability.