Skip to content

CFP: Include BGP peer capabilities into sysdump #30785

@YutaroHayakawa

Description

@YutaroHayakawa

Cilium Feature Proposal

Include BGP peer capabilities into sysdump for better supportability

Is your proposed feature related to a problem?

We needed to ask users to provide an output from the peer side like this several times. When the session is established, Cilium (GoBGP) knows the peer's capabilities. In such a case, we don't need to ask for peer's capabilities.

Describe the feature you'd like

  • Agent-level CLI (e.g. cilium-dbg) to show peer's capabilities
  • Global-level CLI to show peer's capabilities (e.g. Cilium CLI)
  • Include the output of agent-level CLI into sysdump

(Optional) Describe your proposed solution

We can extend an existing cilium-dbg bgp peers command (which means extend agent API) to include peer capabilities. Cilium CLI can collect the output of the cilium-dbg command and show a cluster-wide view. We do a similar thing for cilium routes. As we do for the path attributes in the cilium routes command, we can encode raw capability binaries into base64 and pretty print it using the GoBGP library on the receiver side. So that we don't need to write String() for every capability.

Metadata

Metadata

Assignees

Labels

area/bgpImpacts the Border Gateway Protocol feature.good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.help-wantedYou can help! Post a detailed plan on the issue or create a PR to solve this issue.kind/cfpCilium Feature Proposalkind/featureThis introduces new functionality.

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions