-
Notifications
You must be signed in to change notification settings - Fork 3.7k
CI: New tests fail on all non-rebased pull requests #15474
Copy link
Copy link
Open
Labels
area/CIContinuous Integration testing issue or flakeContinuous Integration testing issue or flakearea/CI-improvementTopic or proposal to improve the Continuous Integration workflowTopic or proposal to improve the Continuous Integration workflowpinnedThese issues are not marked stale by our issue bot.These issues are not marked stale by our issue bot.
Description
Because of the new image build system, whenever we create a new Jenkins test, it will fail in all in-flight pull requests once merged. Examples can be seen in #15472 and #15469.
This is happening because Jenkins attempts to rebase the code before executing tests. Since images are built externally, Jenkins rebases the code for the tests only. The image build process doesn't rebase before building. We therefore run new tests with an agent or operator that doesn't support the tested feature yet.
We have at least three ways to fix this:
- We extend the image build process to attempt a rebase similarly to Jenkins.
- We tell everyone to ignore new, failing tests if they haven't rebased yet and hope we don't introduce too many new Jenkins tests.
- We disable rebasing in Jenkins. That may end up being worse though.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/CIContinuous Integration testing issue or flakeContinuous Integration testing issue or flakearea/CI-improvementTopic or proposal to improve the Continuous Integration workflowTopic or proposal to improve the Continuous Integration workflowpinnedThese issues are not marked stale by our issue bot.These issues are not marked stale by our issue bot.