Skip to content

hubble/relay: implement unit tests #11425

@rolinh

Description

@rolinh

As highlighted when working on #11397, it is impossible to implement good unit tests for pkg/hubble/relay without refactoring the Server code.

There are notably these major issues that need to be addressed:

  • The peers syncing logic is tightly coupled to the relay server. This should be extracted and turned into something that can easily be mocked for tests.
  • Given options are used to start gRPC clients for both the peer service and the observer service. This should be changed such that a client interface can be used and mocks implemented.

Metadata

Metadata

Assignees

Labels

kind/enhancementThis would improve or streamline existing functionality.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions