Conversation
[upstream pytorch#3450] [ai_generated] XPU crash on torch.linalg.ldl_solve with invalid pivots instead of raising validation error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for ZhaoqiongZ/torch-xpu-ops-exp#346
Issue: [upstream pytorch#3450] [ai_generated] XPU crash on torch.linalg.ldl_solve with invalid pivots instead of raising validation error
Root Cause: torch.linalg.ldl_solve falls back to CPU on XPU via XPUFallback.template. The upstream fix (pytorch#181032) added pivot validation (
1 <= |pivot| <= N) insideldl_solve_kernelinBatchLinearAlgebraKernel.cpp, which only runs on the CPU dispatch path. When XPU is used, the fallback occurs after the IMPL function (linalg_ldl_solve_outinBatchLinearAlgebra.cpp) copies B to result and callsldl_solve_stubwith the XPU device type — but the XPU fallback dispatches down to the CPU kernel without going through the validated path first, triggering a segfault in LAPACK SYTRS before validation runs.Failed Tests:
torch.linalg.ldl_solveon XPU with out-of-range pivots.Diff stat: