Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 😄
Not entirely sure if this should be 0.4.x or 0.5, so please feel free to let me know if I'm on the wrong branch.
Submitting this to update the calling of windows system functions (I believe someone else may be taking a look at the subtracting 1900 issue). This is mainly meant to remove the panics that are being thrown whenever an invalid date is provided to the
windows_sysfunctions along with providing some default struct functions to minimize the use ofmem::zeroed.This does add an
unwraptoTimeSpec::localthat would still cause a panic on any error cases, but the behavior would essentially remain consistent with the current behavior.