Skip to content

Add missing features documentation#1260

Merged
pitdicker merged 1 commit intochronotope:0.4.xfrom
Stygmates:fix-docs
Sep 6, 2023
Merged

Add missing features documentation#1260
pitdicker merged 1 commit intochronotope:0.4.xfrom
Stygmates:fix-docs

Conversation

@Stygmates
Copy link
Copy Markdown

@Stygmates Stygmates commented Sep 6, 2023 •
edited
Loading

The rustdoc isn't up to date with the readme and features documentation is missing. This PR solves this.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #1260 (589e51f) into 0.4.x (8509c25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            0.4.x    #1260   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          37       37           
  Lines       16448    16448           
=======================================
  Hits        15030    15030           
  Misses       1418     1418
Files Changed Coverage Δ
src/lib.rs 95.58% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stygmates Stygmates mentioned this pull request Sep 6, 2023
Merged
@pitdicker
Copy link
Copy Markdown
Collaborator

pitdicker commented Sep 6, 2023 •
edited
Loading

What I still wanted to do was sync the documentation in lib.rs with the changes to the README in #1111. Do you want to copy those also, instead of only the features (except the part about the license)?

@Stygmates
Copy link
Copy Markdown
Author

Stygmates commented Sep 6, 2023

What I still wanted to do was sync the documentation in lib.rs with the changes to the README in #1111. Do you want to copy those also, instead of only the features (except the part about the license)?

Done, let me know if you want me to change something else!

djc
djc reviewed Sep 6, 2023
View reviewed changes
@pitdicker
Copy link
Copy Markdown
Collaborator

pitdicker commented Sep 6, 2023

Thank you!

I am not sure what happened, you have parts of the README with lines from the current docs in between them?

pitdicker
pitdicker reviewed Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also squash the commits 😄.

@Stygmates
Copy link
Copy Markdown
Author

Stygmates commented Sep 6, 2023

All done! Thanks for keeping up with me!

pitdicker
pitdicker approved these changes Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pitdicker pitdicker merged commit 84334df into chronotope:0.4.x Sep 6, 2023
@pitdicker pitdicker mentioned this pull request Sep 6, 2023
Closed
@pitdicker pitdicker mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@pitdicker pitdicker pitdicker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Stygmates @pitdicker @djc