Merged
Conversation
Contributor
|
📦 Package Size: 5720 KB |
b0062e2 to
9aab540
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 71.62% 71.64% +0.01%
==========================================
Files 204 204
Lines 7631 7636 +5
Branches 1366 1366
==========================================
+ Hits 5466 5471 +5
Misses 2143 2143
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
929d193 to
6c3ba37
Compare
justin-thurman
approved these changes
Oct 23, 2025
Contributor
justin-thurman
left a comment
There was a problem hiding this comment.
Looks good. I ran a build locally, working as expected. 👍
6c3ba37 to
5b685c3
Compare
Collaborator
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1208
On Node v24+, there's a new warning that appears:
This is caused by us using
shell: truewhen running shell commands. Thankfully, this was fixed inexecav9.5.3 so we simply need to upgrade to fix the warning.In addition to that,
execaCommandis now deprecated and will be removed in v10+ (ref). To avoid those issues in the future, I went ahead and swapped our usage ofexecaCommandwithexecawhich is roughly similar. The biggest difference is we need to parse the command string into an array before callingexeca.📦 Published PR as canary version:
13.3.3--canary.1215.18784607811.0✨ Test out this PR locally via:
npm install chromatic@13.3.3--canary.1215.18784607811.0 # or yarn add chromatic@13.3.3--canary.1215.18784607811.0