fix: replace deprecated NSD resolve APIs for API 34+#73
Merged
Conversation
…host On API 34+ (Android 14), use registerServiceInfoCallback/hostAddresses instead of the deprecated resolveService/host APIs. The legacy code path is preserved behind @Suppress("DEPRECATION") for older devices. The shared TXT-record parsing logic is extracted into handleResolvedService to avoid duplication between the two code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NsdManager.resolveService()andNsdServiceInfo.hostare deprecated. This PR adds version-checked code paths that use the modernregisterServiceInfoCallbackandhostAddressesAPIs on API 34+, while preserving the legacy path (with@Suppress("DEPRECATION")) for older devices.handleResolvedService()to avoid duplication between the two code paths.Test plan
NsdDiscoveryManager.ktin build output