Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thaw()was restoring the full pre-disconnect measurement count, causingisConvergedto return true immediately. This madeTimeSyncManageruse the slow converged burst strategy (3s interval, 3 bursts) instead of the aggressive initial strategy needed to re-establish accurate sync with the server.measurementCounttoMIN_MEASUREMENTS(2) on thaw soisReadystays true (playback continues) butisConvergedreturns false (forces fast re-sync).Test plan
./gradlew :shared:testAndroidHostTest --tests "com.sendspindroid.sendspin.SendspinTimeFilterTest"(pre-existing stabilityScore test failure is unrelated)