Add stable keys to LazyColumn/LazyRow items#62
Merged
Conversation
Without stable keys, Compose recomposes every visible item when the list changes. Add key lambdas to the three remaining items/itemsIndexed calls that were missing them: - NowPlayingHeadUnit: use queueItemId for up-next queue items - SearchScreen: use media type name for filter chips - BrowseListScreen: use sort option name for sort chips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keylambdas to threeitems/itemsIndexedcalls that were missing them, preventing unnecessary recomposition of every visible item on list changes.itemsIndexednow usesqueueItemIdas key.itemsnow uses the media type enum name as key.itemsnow uses the sort option enum name as key.All other
items/itemsIndexedcalls across the codebase already had stable keys.Test plan