fix: move pendingExitDraining access to main thread in onReconnecting#59
Merged
fix: move pendingExitDraining access to main thread in onReconnecting#59
Conversation
The onReconnecting() callback runs on the WebSocket IO thread, but pendingExitDraining is a plain boolean only accessed from the main thread everywhere else. Writing it from the IO thread is a data race. Move the pendingExitDraining = false assignment into the mainHandler.post block where all other accesses occur. The enterDraining() call remains outside the post block since it is already fully thread-safe (guarded by SyncAudioPlayer.stateLock), preserving the intent that disconnect handlers immediately see DRAINING state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onReconnecting()wherependingExitDrainingwas written from the WebSocket IO thread, while all other accesses are on the main threadpendingExitDraining = falseassignment into themainHandler.postblockenterDraining()remains outside the post block since it is already thread-safe (guarded bySyncAudioPlayer.stateLock), preserving the intent that disconnect handlers immediately see DRAINING stateTest plan