fix: move bitmap decoding off main thread in onArtwork#57
Merged
Conversation
The onArtwork() callback was decoding and scaling bitmap data on the main thread via mainHandler.post, which can cause UI jank on large images. Move the decode and scale operations to Dispatchers.IO using the existing serviceScope coroutine, keeping only the state assignment and MediaSession update on the main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BitmapFactory.decodeByteArrayandscaleArtworkfrommainHandler.posttoDispatchers.IOvia the existingserviceScopecoroutinecurrentArtwork) andupdateMediaSessionArtworkremain on the main thread sinceserviceScopeusesDispatchers.MainTest plan