Remove dead isAvailable stub from MusicAssistantManager#56
Merged
Conversation
The isAvailable property was a StateFlow<Boolean> permanently returning false -- it was never wired to connectionState and had zero callers. All call sites already use connectionState.value.isAvailable instead. Remove the dead property and update the class-level KDoc to reference connectionState rather than the deleted isAvailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MusicAssistantManager.isAvailable, aStateFlow<Boolean>that was permanently hardcoded tofalseand never wired toconnectionStateconnectionState.value.isAvailable(the property onMaConnectionState), so this stub had zero consumersconnectionStateinstead of the deleted propertyTest plan
MusicAssistantManager.isAvailableexist in the codebase (all usage isconnectionState.value.isAvailable)./gradlew assembleDebugbuilds successfullyMaConnectionStateIsAvailableTeststill pass (they testMaConnectionState.isAvailable, not the removed property)