fix: add @Volatile to pendingExitDraining for thread safety#54
Merged
fix: add @Volatile to pendingExitDraining for thread safety#54
Conversation
pendingExitDraining is written from the WebSocket IO thread in onReconnecting() and read/written from the main thread in onReconnected() and completePendingExitDraining(). Without @volatile, the JVM provides no guarantee that the write on the IO thread is visible to the main thread, which could cause a stale read and skip the exitDraining() call after reconnection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendingExitDrainingis written from the WebSocket IO thread (onReconnecting) and read/written from the main thread (onReconnected,completePendingExitDraining). Without@Volatile, the JVM has no memory visibility guarantee for the cross-thread access, which could cause a stale read and skip theexitDraining()call after reconnection.@Volatileannotation to ensure writes are immediately visible across threads, consistent with the existing@VolatileonsyncAudioPlayer(line 123).Test plan
./gradlew assembleDebug