fix: flush AudioTrack on pause so audio stops immediately#52
Merged
Conversation
Previously, pause() called audioTrack.pause() without flush(), leaving up to ~1 second of audio draining through the hardware DAC buffer. Now pause() also calls flush() to clear the hardware buffer. The chunk-level queue is preserved for seamless resume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where pressing pause doesn't immediately stop audio output -- audio continues playing for up to ~1 second while the AudioTrack hardware buffer drains.
Root cause:
SyncAudioPlayer.pause()calledaudioTrack.pause()withoutaudioTrack.flush(). Thepause()API stops the AudioTrack from reading new data from its ring buffer, but any audio already queued in the hardware buffer (~1 second at 48kHz) continues playing through the DAC.Fix: Add
audioTrack.flush()afteraudioTrack.pause(). This clears the hardware buffer so audio stops immediately. The chunk-level queue is preserved for seamless resume --resume()already resets DAC calibrations and sync state, and the playback loop refills the AudioTrack from the chunk queue.Test plan
PauseFlushTestvalidates pause/flush/resume ordering