Merged
Conversation
croniter 6.0.0 has two unbounded memory leaks ([#182](pallets-eco/croniter#182), [#195](pallets-eco/croniter#195)) that are fixed in main but unreleased — and the project was declared unmaintained by Pallets Community Ecosystem in March 2025, so no release is coming. It also drags in pytz and python-dateutil as transitive deps. cronsim is actively maintained (~280 lines, zero deps, Python 3.10+), used in production by Healthchecks.io, and handles DST via zoneinfo natively. One gap: cronsim doesn't support Vixie keywords (@daily, @hourly, etc.), so we add a small mapping dict that expands them before passing to CronSim. Also extracted `Cron.next_time()` so tests mock at docket's abstraction level rather than the library's internals, and added contract tests that exercise the real cronsim integration (sequential times, timezone handling, keyword validity). Companion conda-forge PR: conda-forge/pydocket-feedstock#34 Closes #362 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 3166 3172 +6
Branches 26 26
=========================================
+ Hits 3166 3172 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
croniter 6.0.0 has two unbounded memory leaks
(#182,
#195) that are
fixed in main but unreleased — and the project was declared unmaintained
by Pallets Community Ecosystem in March 2025, so no release is coming.
It also drags in pytz and python-dateutil as transitive deps.
cronsim is actively maintained (~280 lines, zero deps, Python 3.10+),
used in production by Healthchecks.io, and handles DST via zoneinfo
natively. One gap: cronsim doesn't support Vixie keywords (@daily,
@hourly, etc.), so we add a small mapping dict that expands them before
passing to CronSim.
Also extracted
Cron.next_time()so tests mock at docket's abstractionlevel rather than the library's internals, and added contract tests that
exercise the real cronsim integration (sequential times, timezone
handling, keyword validity).
Companion conda-forge PR: conda-forge/pydocket-feedstock#34
Closes #362
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com