Log errors from failing Perpetual tasks#361
Merged
chrisguidry merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
When a Perpetual task fails, `on_complete()` returns `True` which tells the Worker "I handled it" — skipping the normal error log. The reschedule works fine, but the exception is completely invisible. Now we log at ERROR with the full traceback before the reschedule info line. Also fixes the logger names in the private dependency modules (`_perpetual`, `_concurrency`, `_retry`) to use `docket.dependencies` instead of leaking internal names like `docket.dependencies._perpetual` into log output. Closes #360 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 3163 3166 +3
Branches 26 26
=========================================
+ Hits 3163 3166 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Same fix as the Perpetual error logging — Retry.handle_failure() was returning True and swallowing the exception. Now each retry attempt logs the error at ERROR level with the full traceback before the reschedule info line. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Perpetual task fails,
on_complete()returnsTruewhich tells the Worker "I handled it" — skipping the normal error log. The reschedule works fine, but the exception is completely invisible. Now we log at ERROR with the full traceback before the reschedule info line.Also fixes the logger names in the private dependency modules (
_perpetual,_concurrency,_retry) to usedocket.dependenciesinstead of leaking internal names likedocket.dependencies._perpetualinto log output.Closes #360
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com