Improve keyboard mappings#96
Merged
Merged
Conversation
- Introduced a new option `--no-nvidia` in args.sh to disable NVIDIA auto-detection. - Updated extract-frame.sh and report_generator.py to utilize NVIDIA hardware acceleration for frame extraction. - Enhanced verify_output.py and verify_tint.py to support NVIDIA hardware acceleration in frame processing. - Removed obsolete script send_sid_songlengths.py. - Added basic OBS Studio configuration for NVIDIA encoder in basic.ini.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds NVIDIA hardware acceleration support for E2E tests and improves keyboard mappings to better support C64 interaction.
Changes:
- Added NVIDIA GPU detection and automatic NVENC/NVDEC acceleration for E2E test frame processing
- Implemented Ctrl+Meta keyboard chord to toggle between C64 text and graphics modes
- Fixed $ key handling by prioritizing printable text over ambiguous virtual key codes
- Removed obsolete send_sid_songlengths.py script
- Extended keymap system to support multi-value sequences for mode switching
Reviewed changes
Copilot reviewed 35 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/e2e.sh | Adds configure_nvidia_accel() function with feature detection and override merging |
| tests/e2e/util/*.py | Adds NVIDIA hwaccel support to ffmpeg commands in verification scripts |
| tests/e2e/assertions/*.py | Adds hwaccel helper usage to frame extraction in assertion modules |
| src/c64-source.c | Implements Ctrl+Meta chord detection state machine and prioritizes text over vkey |
| src/c64-keyboard.c | Adds multi-value sequence support to keymap entries with cycling logic |
| src/c64-types.h | Adds keyboard state tracking fields for chord detection |
| data/keymaps/*.c64keymap.ini | Adds Ctrl+Meta=0x0E,0x8E mapping for text/graphics mode toggle |
| tests/e2e/config/obs-studio-overrides/nvidia/basic.ini | Adds NVENC encoder configuration |
| local-build.sh | Adds --no-nvidia flag support (with duplicate handling issue) |
| util/send_sid_songlengths.py | Removes obsolete script |
| tests/e2e/results/ntsc_default/* | Updates test results from new test run |
- Introduced multiple test scripts to validate error handling for various scenarios: - Array bounds errors - Array index type mismatches - Scalar usage of arrays - Zero-length arrays - Illegal quantity errors - Invalid escape sequences - Map key type mismatches - Scalar usage of maps - Mixed-type comparison errors - Undefined function errors - Invalid WAIT memory arguments - Invalid WAIT UNTIL string - Each test includes expected trace outputs to ensure accurate error reporting. - Updated the test suite to include new error cases in the expected failures list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved keyboard mappings: