tests(e2e): use concurrency=1 on CI for frame analysis and assertions#90
Merged
Merged
Conversation
…sertions Reduce concurrency used for E2E post-recording frame extraction, frame progression analysis, and all assertion checks to 1 (instead of cpu_count) when running on CI. Local runs remain unchanged at full cpu_count. Changes: - Add _is_ci() helper to detect CI environment (CI or GITHUB_ACTIONS env vars) - assertions/runner.py: Use concurrency=1 on CI for assertion execution - assertions/frame_progression.py: Use concurrency=1 on CI for profile scanning This minimal change helps stabilize CI builds that may have contention or timing sensitivity during parallel video processing operations. Co-authored-by: chrisgleissner <3969147+chrisgleissner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AV sync validation for no matching pop pairs
tests(e2e): use concurrency=1 on CI for frame analysis and assertions
Jan 13, 2026
chrisgleissner
approved these changes
Jan 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves E2E test stability on CI environments by limiting parallelism during frame analysis and assertion execution to prevent resource contention.
Changes:
- Adds CI environment detection (
_is_ci()helper) based onCIorGITHUB_ACTIONSenvironment variables - Limits parallel workers to 1 on CI for assertion execution and frame profile scanning
- Preserves full CPU parallelism for local development runs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/e2e/assertions/runner.py | Adds CI detection and limits assertion execution workers to 1 on CI (preserves cpu_count() locally) |
| tests/e2e/assertions/frame_progression.py | Adds CI detection and limits frame profile scanning workers to 1 on CI (preserves cpu_count() locally) |
Extract duplicated is_ci() function from runner.py and frame_progression.py into base.py to follow DRY principle. Changes: - Add is_ci() to assertions/base.py as a shared helper - Import is_ci from base in runner.py (removed duplicate) - Import is_ci from base in frame_progression.py (removed duplicate) This eliminates code duplication and provides a single source of truth for CI environment detection across all assertion modules. Co-authored-by: chrisgleissner <3969147+chrisgleissner@users.noreply.github.com>
Copilot stopped work on behalf of
chrisgleissner due to an error
January 13, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.