Reuse E2E infrastructure for real device test#85
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes two temporary tracking documents (PLANS.md and INVESTIGATIONS.md) from the repository root and updates .gitignore accordingly. Despite the PR title suggesting E2E test consolidation, the actual changes only involve documentation cleanup.
Changes:
- Deleted PLANS.md (97 lines) containing a completed multi-hour task plan from 2026-01-11
- Deleted INVESTIGATIONS.md (192 lines) containing resolved bug investigations
- Updated .gitignore to remove references to deleted files and clean up duplicate entries
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PLANS.md | Removed completed task plan for fixing AV-sync test, packaging, and crash issues |
| INVESTIGATIONS.md | Removed resolved investigations including UDP packet loss and real-device streaming issues |
| .gitignore | Cleaned up entries for deleted files (PLANS.md, INVESTIGATIONS.md, build-docker.sh) and removed duplicate AGENTS.md entry |
- Rename mocked scenario ntsc_default_debug → ntsc_default_avsync - Add device-backed scenario ntsc_default_avsync_device (local-only, ci_skip) - Extend E2E harness to support packet_source=device via WebSocket A/V sync toggle - Remove legacy real-device runner scripts (real-device-av-sync.sh, real_device_av_sync.py) - Remove --real-device flag from local-build.sh (replaced by unified E2E scenario) - Add deterministic suite runner (tests/e2e/run_avsync_suite.sh) - Update CI workflow to use renamed scenario, exclude device scenario - Update docs for unified scenario + suite runner Local validation: Mock scenario passed all assertions (4/4), device scenario correctly requires real hardware (expected failure without device).
- Don’t treat low device packet sequences as mock data\n- Use av-sync.csv as authoritative A/V offset source\n- Wait for av-sync.csv to quiesce before teardown\n- Validate AV SYNC logs against av-sync.csv pop maxima when present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.