Add OBS Image source support to C64 Stream Effects; update documentation#112
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves end-user documentation around “perfect scan lines” and makes that documentation discoverable from inside OBS by updating UI help text and packaging README.md with the plugin.
Changes:
- Add new/updated screenshots in
docs/images/and embed the new “Perfect Scan Lines” screenshot in the README. - Update localization files to add
C64Streamand a new, more detailedPreservePreviewSize.Description. - Adjust CMake/build/dev-install scripts to copy/install resources under a
data/subdirectory and includeREADME.mdas a shipped resource.
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/images/source-transform-edit.png | Adds/updates screenshot used in README for OBS source transform editing. |
| docs/images/perfect-scan-lines.png | Adds new screenshot illustrating perfect scan line setup. |
| README.md | Embeds the new “Perfect Scan Lines” image in the documentation. |
| data/locale/en-US.ini | Adds C64Stream string and updates PreservePreviewSize.Description. |
| data/locale/en-GB.ini | Adds C64Stream and adds PreservePreviewSize label + description. |
| data/locale/de-DE.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/es-ES.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/fr-FR.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/it-IT.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/ja-JP.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/ko-KR.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/nl-NL.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/pl-PL.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/pt-BR.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/ru-RU.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/sv-SE.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| data/locale/zh-CN.ini | Adds C64Stream and adds PreservePreviewSize description text. |
| cmake/windows/helpers.cmake | Copies per-resource installs into rundir/.../<target>/data. |
| cmake/linux/helpers.cmake | Installs/copies per-resource installs into a .../<target>/data path. |
| cmake/macos/helpers.cmake | Places extra resources into Resources/data in the bundle. |
| CMakeLists.txt | Adds README.md as an installed resource via target_add_resource(). |
| build | Copies README.md into plugin data/ during install steps. |
| .vscode/tasks.json | Copies README.md into the OBS plugin data/ directory in dev tasks. |
…cales and documentation
…s for NTSC image effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.