Add dynamic keymap reloading on selection change#106
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the OBS source to support runtime keyboard keymap switching and adjusts the built-in “Positional US” keymap mappings to better match intended positional/behavioral rules.
Changes:
- Reload the active keyboard keymap in
c64_update()when thekeyboard_keymapsetting changes. - Refine
positional_us.c64keymap.inimappings for punctuation and navigation/edit keys (e.g., Insert/Delete, semicolon/quote, shifted punctuation).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/c64-source.c | Adds keymap reload logic during settings updates. |
| data/keymaps/positional_us.c64keymap.ini | Updates positional US key mappings and accompanying comments. |
…Shift+Equal, Home, and Shift+Home
- Use snprintf instead of strncpy in c64_update() to guarantee NUL-termination of keyboard_keymap_name; also record the attempted name before load so repeated c64_update() calls on a missing keymap don't spam the log. - Update test assertions to match current positional_us keymap: Shift+Home → 0x94 (INS), Shift+Equal → 0x3D (=). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.