Enhance keymap definitions and improve E2E test reliability#105
Merged
Conversation
chrisgleissner
commented
Mar 17, 2026
Owner
- Updated positional US keymap with additional shifted punctuation mappings.
- Modified symbolic DE, FR, IT, NL, and UK keymaps to correct character mappings.
- Added new function to check for visible text in key event handling.
- Improved E2E test steps with retry logic and detailed logging for failures.
- Updated positional US keymap with additional shifted punctuation mappings. - Modified symbolic DE, FR, IT, NL, and UK keymaps to correct character mappings. - Added new function to check for visible text in key event handling. - Improved E2E test steps with retry logic and detailed logging for failures.
Contributor
There was a problem hiding this comment.
Pull request overview
Enhances keyboard input handling and keymap coverage (including locale-specific characters) while improving CI E2E stability by retrying flaky runs.
Changes:
- Expanded key translation to preserve “visible” (non-control) text even when it’s not a single ASCII printable character.
- Updated positional US and symbolic DE/FR/IT/NL/UK keymaps (and corresponding tests) to correct/extend PETSCII mappings.
- Wrapped E2E workflow steps with retry logic and improved step-summary reporting.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/script/test_interact_key.c |
Adds test cases for UTF-8 visible text translation and additional PETSCII expectations. |
src/c64-interact-key.c |
Introduces has_visible_text() and uses it to preserve non-control text in translated key events. |
data/keymaps/positional_us.c64keymap.ini |
Adds additional shifted punctuation/control mappings (e.g., Shift+Minus/Equal/etc.). |
data/keymaps/symbolic_de.c64keymap.ini |
Corrects German locale character mappings and adds uppercase variants. |
data/keymaps/symbolic_fr.c64keymap.ini |
Adds uppercase accented mappings and removes redundant Shift+4 entry. |
data/keymaps/symbolic_it.c64keymap.ini |
Adds uppercase accented mappings and removes redundant Shift+4 entry. |
data/keymaps/symbolic_nl.c64keymap.ini |
Removes redundant Shift+4 entry. |
data/keymaps/symbolic_uk.c64keymap.ini |
Removes redundant Shift+4 entry. |
.github/workflows/build-project.yaml |
Replaces inline E2E shell runs with nick-fields/retry@v3 and adds richer step summary output. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ier key behavior - Enhanced `c64_key_click` function to correctly identify printable UTF-8 characters, ensuring multi-byte characters are handled appropriately. - Adjusted modifier key logic to differentiate between Alt and AltGr, preventing incorrect CBM modifier bit setting when AltGr is detected. - Added regression tests for UTF-8 character handling and ensured all necessary PETSCII codes are reachable through keymaps. - Consolidated keymap audit findings into a comprehensive document, addressing various issues related to key mappings across different locales and ensuring compliance with user accessibility standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.