Refactor build scripts: Replace local-build.sh with build and build.bat#103
Merged
Conversation
chrisgleissner
commented
Jan 31, 2026
Owner
- Introduced build.bat for Windows to streamline the build process.
- Updated documentation to reflect changes from local-build.sh to build.
- Adjusted commands in various markdown files to use the new build script.
- Ensured that all references to local-build.sh are replaced with build for consistency.
- Introduced build.bat for Windows to streamline the build process. - Updated documentation to reflect changes from local-build.sh to build. - Adjusted commands in various markdown files to use the new build script. - Ensured that all references to local-build.sh are replaced with build for consistency.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors local build tooling and documentation by introducing build.bat for Windows and updating docs to reference the new build script instead of local-build.sh.
Changes:
- Added a Windows build wrapper (
build.bat). - Refactored
buildscript CLI (new--platform/-poption style, updated help/arg parsing). - Updated various docs to reference the new build entrypoints and removed older CI/Copilot docs.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/script/fuzz/README.md | Updates fuzzing instructions to use ./build. |
| docs/testing-strategy.md | Updates recommended local test workflow to use ./build. |
| doc/testing/e2e.md | Updates E2E quick start commands to use ./build. |
| doc/developer.md | Updates developer workflow docs to use build/build.bat. |
| doc/c64script/c64script-trace-validation.md | Updates trace validation commands to use ./build. |
| build.bat | Adds Windows wrapper script intended to invoke the build process via bash. |
| build | Updates CLI usage/argument parsing and some messaging around platform selection and E2E. |
| README.md | Refreshes TOC formatting and updates one local-build.sh reference to ./build. |
| AGENTS.md | Condenses and updates agent guardrails + build/test commands to use ./build. |
| .github/docker/README.md | Updates Docker build instructions to use ./build. |
| .github/copilot-instructions.md | Replaces detailed instructions with a pointer to AGENTS.md. |
| .github/build-instructions.md | Removes CI/Copilot build instructions doc. |
| .github/COPILOT_DEPENDENCIES.md | Removes Copilot dependency documentation. |
Comments suppressed due to low confidence (2)
build:1517
--configassumes a following value ($2) but doesn't validate it. Withset -u, running./build --config(or--configat end) will crash with an "unbound variable" instead of a clear usage error. Add the same kind of argument-count/"next token is option" validation used for--platformand print a helpful error message.
build:1745- The "Next steps" hint says "Run E2E tests" but suggests
--e2e-scenarios(runs all scenarios) rather than the default single-scenario--e2e. Either change the suggested command to--install --e2e(or-i -e), or adjust the message text to explicitly say it runs all scenarios.
…out handling - Refactor build commands in README and developer guide for consistency - Update build.bat to call the new build script with appropriate parameters - Enhance timeout management in test scripts for better execution control - Remove outdated testing strategy document
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.