(#23) Prevent creation of empty NuGet.Config file

gep13 · gep13 · commit a211f1975a04 · 2021-05-06T07:08:27.000+01:00
As Chocolatey, we never want to create the NuGet.Config file, as this is
not used by Chocolatey at all. As such, rather than GetOrCreateDocument,
if the filepath doesn't exist, simply return the default empty
XDocument, which is exactly what would have been returned after creating
the file.

The existing coding style has been adhered to here, and as little
changes as possible have been made.
diff --git a/src/Core/Configuration/Settings.cs b/src/Core/Configuration/Settings.cs
@@ -44,7 +44,19 @@ public Settings(IFileSystem fileSystem, string fileName, bool isMachineWideSetti
             _fileSystem = fileSystem;
             _fileName = fileName;
             XDocument conf = null;
-            ExecuteSynchronized(() => conf = XmlUtility.GetOrCreateDocument("configuration", _fileSystem, _fileName));
+
+            // As Chocolatey, we never want to create the NuGet.Config file, as this is not used by Chocolatey at all.
+            // As such, rather than GetOrCreateDocument, if the filepath doesn't exist, simply return the default empty
+            // XDocument, which is exactly what would have been returned after creating the file.
+            if (_fileSystem.FileExists(_fileName))
+            {
+                ExecuteSynchronized(() => conf = XmlUtility.GetDocument(_fileSystem, _fileName));
+            }
+            else
+            {
+                conf = new XDocument(new XElement("configuration"));
+            }
+
             _config = conf;
             _isMachineWideSettings = isMachineWideSettings;
         }
