Adding coverage test for TaskResumeFromISR #4
Conversation
* Adding coverage test for xTaskResumeFromISR
...S/Test/CMock/smp/single_priority_no_timeslice_covg/single_priority_no_timeslice_covg_utest.c
Outdated
Show resolved
Hide resolved
| * This test can be run with FreeRTOS configured for any number of cores | ||
| * greater than 1 . | ||
| * | ||
| * Tasks are created prior to starting the scheduler. |
There was a problem hiding this comment.
I think the description could probably be simpler (depending on the test). This portion should describe any setup or pre-conditioning required to take a particular code path. Perhaps we should also include a code snippet of the specific code path we are taking for coverage.
My concern is that when code changes it is difficult to determine which code coverage test needs to be updated to match. This can result in creating unnecessary coverage tests over time.
There was a problem hiding this comment.
Code could also be changed in the future. In this case, code snippet will need extra effort to maintain.
I would like to use API and comment for tracking. At least when we change the code of an API, we can search for the test cases we may also need to update.
test_coverage_<API>_<test description>
<API> can be public API or private API.
...S/Test/CMock/smp/single_priority_no_timeslice_covg/single_priority_no_timeslice_covg_utest.c
Outdated
Show resolved
Hide resolved
* Move the covg test to the folder have same FreeRTOSConfig.h * Add configUSE_TICKLESS_IDLE config in single_priority_no_timeslice test group
* Move the utest.c file to single_priority_timeslice folder
Adding coverage test for xTaskResumeFromISR
Description
Test Steps
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.