Fix Carthage for Xcode 8.1#153
Merged
chiahsien merged 18 commits intochiahsien:developfrom Nov 1, 2016
Merged
Conversation
Remove cached layout attribute objects when collection view has 0 sectio...
Revert "Remove cached layout attribute objects when collection view has ...
Owner
|
Thanks |
Closed
|
@chiahsien could you do a new release that includes this fix and the latest changes? The latest release 0.9.5 is not working with carthage as it does not have this fix in so having to resort the a specific commit in the cartfile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Carthage for Xcode 8.1. It removes the shared "framework header"
CHTCollectionViewWaterfallLayout.hthat was importing the real header file also calledCHTCollectionViewWaterfallLayout.h. It then directly exposes the real header as a public header.Xcode 8.1 seems to have a different way of handling headers with the same name. Xcode 8.0 and below chose the "real header" while completely ignoring the shared header. Thus the shared header was never actually used.
This PR also changes the README's installation instructions to mention Carthage.