Adds error notification, prevent unneeded changes#60
Merged
chhoumann merged 1 commit intochhoumann:masterfrom Feb 9, 2022
Merged
Conversation
Owner
|
PR looks great, thank you very much @ryanjamurphy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Re: issue Kanban helper function throws error #45, this PR adds a user-facing notification to help users see which files are missing the YAML metadata property Kanban Helper is looking for.
Previously, if Kanban Helper was operating on a board, when a user changed a card, Kanban Helper would rewrite the metadata of every card on the board, even if there was no change to a linked file's metadata. This led to every file e.g., getting a new
date modifiedon the file system. I've added a check,const propertyHasChanged = (targetProperty.content != heading);, which returnstrueif the linked file's metadata property has a value that is different from the one the user has changed it to. Kanban helper will therefore only runupdatePropertyInFileifpropertyHasChangedis true.Thanks for a fantastic plugin!