Merged
Conversation
Owner
|
Hello @crystalin, thanks for the PR. Do you have a link where it fails in the context of srtool ? I need some updates here in general for the new version of Is it blocking you for now? Does your CI fail due to that ? The issue you linked is super old so I wonder if |
Contributor
Author
|
This happens when the CI is run in self hosted (even if jq is the exact
same version).
I've had this issue before in some other project. On jq side it is not a
bug but an intended feature.
See
https://github.com/crystalin/moonbeam/runs/2918808565?check_suite_focus=true
for the error on then CI
…On Sat, Jun 26, 2021, 6:28 AM Chevdor ***@***.***> wrote:
Hello @crystalin <https://github.com/crystalin>, thanks for the PR. Do
you have a link where it fails in the context of srtool ?
I need some updates here in general for the new version of srtool so I
will test your PR while testing the rest.
Is it blocking you for now? Does your CI fail due to that ?
The issue you linked is super old so I wonder if jq was not fixed in the
meantime as I did not run into the issue yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQMIEETHLJGJKDHIXSTG3TUWTVPANCNFSM47KZWLPA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jq without
.fails when piped. See jqlang/jq#1110this PR prevents this from happening