Query and QueryLens as type aliases of a QueryBase struct.#9
Open
ItsDoot wants to merge 1 commit intochescock:query-owned-state-simplefrom
Open
Query and QueryLens as type aliases of a QueryBase struct.#9ItsDoot wants to merge 1 commit intochescock:query-owned-state-simplefrom
Query and QueryLens as type aliases of a QueryBase struct.#9ItsDoot wants to merge 1 commit intochescock:query-owned-state-simplefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
'statelifetime, which removes the need for thePhantomDatafield.Solution
Querystruct toQueryBaseand addQueryas a type alias ofQueryBase(note this is a shallow rename, not a deep one).QueryLensinto a type alias ofQueryBase.I like this version for being more explicit about "am I implementing something for just
Queryor for both it andQueryLens?" The small downside is that type hints will probably showQueryvars/params asQueryBase.