Skip to content

Allow nightly builds to fail until #1731 can be fixed.#1791

Merged
webknjaz merged 1 commit intomasterfrom
bugfix/1731-bypass-nightly
Jul 3, 2019
Merged

Allow nightly builds to fail until #1731 can be fixed.#1791
webknjaz merged 1 commit intomasterfrom
bugfix/1731-bypass-nightly

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Jul 2, 2019

No description provided.

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Jul 2, 2019

As you can see, CI is failing due to linters.

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 3, 2019

CI is failing due to linters

No. The failing linter is allowed to fail, which allows the next stage to proceed with running jobs.

The real failures are:

Results (137.32s):
     288 passed
       2 xpassed
       4 failed
         - cherrypy/test/test_httputil.py:62 test_invalid_status[hey-Illegal response status from server ('hey' is non-numeric).]
         - cherrypy/test/test_httputil.py:62 test_invalid_status[status_code1-Illegal response status from server ({'hey': 'hi'} is non-numeric).]
         - cherrypy/test/test_httputil.py:62 test_invalid_status[1-Illegal response status from server (1 is out of range).]
         - cherrypy/test/test_httputil.py:62 test_invalid_status[600-Illegal response status from server (600 is out of range).]
       3 xfailed
       2 skipped

# TODO: fix tests
- python: *pypy3
- env: TOXENV=pre-commit-pep257
- python: nightly
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works:

Your build matrix was set to allow the failure of job 2075.7.

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 3, 2019

The last commit on master was green at the time of merging but after a few days of cron runs of builds against the same commit it became red:
✔️ https://travis-ci.org/cherrypy/cherrypy/builds/551539222 (last green)
https://travis-ci.org/cherrypy/cherrypy/builds/552272394 (first red)

I believe, something has changed in the runtime of the CI. Which is a separate problem itself.

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 3, 2019

Root cause

pytest got upgraded from 4.6.3 to 5.0.0

webknjaz added a commit that referenced this pull request Jul 3, 2019
@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 3, 2019

This should be fixed by 96b34df now.

@webknjaz webknjaz merged commit 7c71787 into master Jul 3, 2019
@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 3, 2019

Okay, 14c12d2 really fixes it.

webknjaz added a commit that referenced this pull request Jul 6, 2019
@jaraco jaraco deleted the bugfix/1731-bypass-nightly branch September 4, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants