build: Update price-feeder version in go.mod#935
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the integration tests to increase oracle jitter tolerance and adjusts fee deviation expectations across multiple test files. The changes address oracle price feed variance by introducing a centralized tolerance constant and replacing exact equality checks with tolerance-based assertions.
- Introduces a new constant
OracleJitterTolerance(5000 ncheq) in a helper package - Increases tolerance values in resource and DID pricing tests from 2,000,000 to 200,000,000 ncheq
- Replaces exact equality assertions with deviation checks in negative resource pricing tests
- Updates dependency versions (ginkgo, gomega, protobuf, and several cloud.google.com packages)
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/helpers/const.go | Adds new constant OracleJitterTolerance for test tolerance values |
| tests/integration/cli_resource_pricing_test.go | Increases tolerance from 2M to 200M ncheq in 6 balance difference assertions |
| tests/integration/cli_resource_pricing_negative_test.go | Replaces exact equality with tolerance-based assertions using new constant |
| tests/integration/cli_diddoc_pricing_test.go | Increases tolerance from 2M to 200M ncheq in 6 balance difference assertions |
| go.work.sum | Updates go workspace dependency checksums |
| go.sum | Updates module dependency checksums |
| go.mod | Updates test framework and dependency versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eengineer1
approved these changes
Nov 4, 2025
Eengineer1
left a comment
Member
There was a problem hiding this comment.
Looks broadly good!
Approved 👍.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.